[PATCH] D41351: [clangd] Expose offset <-> LSP position functions, and fix bugs

2017-12-19 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE321073: [clangd] Expose offset <-> LSP position functions, and fix bugs (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D41351?vs=127345&id=127495#toc Reposi

[PATCH] D41351: [clangd] Expose offset <-> LSP position functions, and fix bugs

2017-12-19 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D41351: [clangd] Expose offset <-> LSP position functions, and fix bugs

2017-12-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, ilya-biryukov, mgorny, klimek. - Moved these functions to SourceCode.h - added unit tests - fix off by one in positionToOffset: Offset - 1 in final calculation was wrong - fixed formatOnType