Re: [PATCH] D41414: [analyzer] Add keyboard j/k navigation to HTML reports

2018-01-02 Thread David Blaikie via cfe-commits
Sure, this is post-commit review feedback. vim with dvorak works in the sense that it's not unusable, but it's pretty awkward (see, for example, discussions like this: http://vim.wikia.com/wiki/Using_Vim_with_the_Dvorak_keyboard_layout ) On Tue, Jan 2, 2018 at 10:03 AM George Karpenkov

Re: [PATCH] D41414: [analyzer] Add keyboard j/k navigation to HTML reports

2018-01-02 Thread George Karpenkov via cfe-commits
This patch has already landed — also IIRC e.g. vim on dvorak also uses hjkl navigation with no issues. > On Dec 25, 2017, at 11:21 AM, David Blaikie wrote: > > any chance this can be implemented based on keyboard layout, so it's good for > dvorak users as well? (maybe it

Re: [PATCH] D41414: [analyzer] Add keyboard j/k navigation to HTML reports

2017-12-25 Thread David Blaikie via cfe-commits
any chance this can be implemented based on keyboard layout, so it's good for dvorak users as well? (maybe it already is, I don't know - just mentioning it in case) On Thu, Dec 21, 2017 at 2:58 PM George Karpenkov via Phabricator via cfe-commits wrote: > This

[PATCH] D41414: [analyzer] Add keyboard j/k navigation to HTML reports

2017-12-21 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321320: [analyzer] Add Javascript to analyzer HTML output to allow keyboard navigation. (authored by george.karpenkov, committed by ). Changed prior to commit: