This revision was automatically updated to reflect the committed changes.
Closed by commit rC322064: ananas: Add shared library support (authored by ed,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41500?vs=127907=129045#toc
Repository:
rC Clang
ed accepted this revision.
ed added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D41500#965157, @zhmu wrote:
> @ed I tried to keep things as much in line as the other
> ::linker::Construct() functions do. Do you wish to stray from that path?
>
> I
zhmu added a comment.
@ed I tried to keep things as much in line as the other
::linker::Construct() functions do. Do you wish to stray from that path?
I actually prefer to keep it like this as it's quite readable already, but YMMV
of course :-)
Repository:
rC Clang
ed added inline comments.
Comment at: lib/Driver/ToolChains/Ananas.cpp:93
CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crti.o")));
-CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crtbegin.o")));
+if (Args.hasArg(options::OPT_shared) ||
zhmu created this revision.
zhmu added a reviewer: ed.
Herald added a subscriber: cfe-commits.
The Ananas Operating System (https://github.com/zhmu/ananas) has shared library
support as of commit 57739c0b6ece56dd4872aedf30264ed4b9412c77.
This change adds the necessary settings to clang so that
