This revision was automatically updated to reflect the committed changes.
Closed by commit rL321412: [clangd] Use Builder for symbol slabs, and use
sorted-vector for storage (authored by sammccall, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41506
Files:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall updated this revision to Diff 128049.
sammccall marked an inline comment as done.
sammccall added a comment.
Address review comments, and update new GlobalSymbolBuilder tool for new API.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41506
Files:
sammccall marked 6 inline comments as done.
sammccall added a comment.
Thanks!
Comment at: clangd/index/Index.cpp:39
+ [](const Symbol , const SymbolID ) {
+ return S.ID == I;
+ });
hokein added inline comments.
Comment at: clangd/index/Index.cpp:76
+SymbolSlab SymbolSlab::Builder::build() && {
+ Symbols = {Symbols.begin(), Symbols.end()}; // Force shrink-to-fit.
+ // Sort symbols so the slab can binary search over them.
use
ilya-biryukov added inline comments.
Comment at: clangd/index/Index.cpp:39
+ [](const Symbol , const SymbolID ) {
+ return S.ID == I;
+ });
Should this be `S.ID < I`?
sammccall updated this revision to Diff 127918.
sammccall added a comment.
minor doc and code layout tweaks
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41506
Files:
clangd/index/FileIndex.cpp
clangd/index/Index.cpp
clangd/index/Index.h
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgrang, klimek.
This improves a few things:
- the insert -> freeze -> read sequence is now enforced/communicated by the
type system
- SymbolSlab::const_iterator iterates over
