[PATCH] D41517: mmintrin.h documentation fixes and updates

This revision was automatically updated to reflect the committed changes. Closed by commit rL327090: [DOXYGEN] Fix doxygen and content issues in mmintrin.h (authored by dyung, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D41517: mmintrin.h documentation fixes and updates

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - thanks https://reviews.llvm.org/D41517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41517: mmintrin.h documentation fixes and updates

craig.topper added a comment. I'm happy. https://reviews.llvm.org/D41517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41517: mmintrin.h documentation fixes and updates

RKSimon added a comment. Any more comments? https://reviews.llvm.org/D41517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung updated this revision to Diff 137333. dyung marked an inline comment as done. dyung added a comment. Update based on feedback from Simon. https://reviews.llvm.org/D41517 Files: lib/Headers/mmintrin.h Index: lib/Headers/mmintrin.h

[PATCH] D41517: mmintrin.h documentation fixes and updates

RKSimon added inline comments. Comment at: lib/Headers/mmintrin.h:1292 /// -/// This intrinsic corresponds to the VXORPS / XORPS instruction. +/// This intrinsic corresponds to the XOR instruction. /// craig.topper wrote: > kromanova wrote: > >

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung marked an inline comment as done. dyung added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// efriedma wrote: >

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung updated this revision to Diff 136221. dyung added a comment. Updated documentation for instruction generated for _mm_cvtsi32_si64, _mm_cvtsi64_si32, _mm_cvtsi64_m64 and _mm_cvtm64_si64 based on feedback. https://reviews.llvm.org/D41517 Files: lib/Headers/mmintrin.h Index:

[PATCH] D41517: mmintrin.h documentation fixes and updates

efriedma added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// RKSimon wrote: > efriedma wrote: > > craig.topper wrote:

[PATCH] D41517: mmintrin.h documentation fixes and updates

RKSimon added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// efriedma wrote: > craig.topper wrote: > > kromanova

[PATCH] D41517: mmintrin.h documentation fixes and updates

efriedma added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// craig.topper wrote: > kromanova wrote: > > I tried clang

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung updated this revision to Diff 129015. dyung added a comment. Updating diff based on review feedback. https://reviews.llvm.org/D41517 Files: lib/Headers/mmintrin.h Index: lib/Headers/mmintrin.h === ---

[PATCH] D41517: mmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/mmintrin.h:1402 /// -/// This intrinsic corresponds to the VPSHUFLW / PSHUFLW instruction. +/// This intrinsic corresponds to the PSHUFLW instruction. /// dyung wrote: > craig.topper wrote: > >

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung added inline comments. Comment at: lib/Headers/mmintrin.h:1402 /// -/// This intrinsic corresponds to the VPSHUFLW / PSHUFLW instruction. +/// This intrinsic corresponds to the PSHUFLW instruction. /// craig.topper wrote: > This is overly specific

[PATCH] D41517: mmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// kromanova wrote: > I tried clang on Linux, x86_64,

[PATCH] D41517: mmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// I tried clang on Linux, x86_64, and if -mavx option is

[PATCH] D41517: mmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/mmintrin.h:1292 /// -/// This intrinsic corresponds to the VXORPS / XORPS instruction. +/// This intrinsic corresponds to the XOR instruction. /// kromanova wrote: > craig.topper wrote: > > PXOR?

[PATCH] D41517: mmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/mmintrin.h:1292 /// -/// This intrinsic corresponds to the VXORPS / XORPS instruction. +/// This intrinsic corresponds to the XOR instruction. /// craig.topper wrote: > PXOR? For which

[PATCH] D41517: mmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/mmintrin.h:88 /// -/// This intrinsic corresponds to the VMOVQ / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// Shouldn't this be MOVQ? Comment

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix instruction mappings/listings for various intrinsics These patches were made by Craig