This revision was automatically updated to reflect the committed changes.
Closed by commit rC322778: [DOXYGEN] Fix doxygen and content issues in
xmmintrin.h (authored by dyung, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41523
Files:
lib/Headers/xmmintrin.h
Index: lib/He
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D41523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
RKSimon added a comment.
Apart for the -Wdocumentation issue (which can be handled separately), is there
anything else stalling this ticket?
https://reviews.llvm.org/D41523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
kromanova added a comment.
In https://reviews.llvm.org/D41523#968776, @craig.topper wrote:
> The builtins are tested in tests like test/CodeGen/sse-builtins.c,
Thank you!
I wonder if -Wdocumentation is working...
I have enabled it for a few tests, like avx-builtins.c, sse-builtins.c and
re-r
dyung updated this revision to Diff 129021.
dyung added a comment.
Update review based on feedback.
https://reviews.llvm.org/D41523
Files:
lib/Headers/xmmintrin.h
Index: lib/Headers/xmmintrin.h
===
--- lib/Headers/xmmintrin.h
++
dyung added inline comments.
Comment at: lib/Headers/xmmintrin.h:1927
///
-/// This intrinsic corresponds to the VPEXTRQ / MOVQ instruction.
+/// This intrinsic corresponds to the VPEXTRQ / PEXTRQ instruction.
///
RKSimon wrote:
> Not necessarily, it could
craig.topper added a comment.
The builtins are tested in tests like test/CodeGen/sse-builtins.c
https://reviews.llvm.org/D41523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kromanova added a comment.
In https://reviews.llvm.org/D41523#968359, @RKSimon wrote:
> Sort of related - should we enable -Wdocumentation (it's currently -Wall and
> -Weverything might be too much) on the respective clang builtin tests?
> Doesn't have to be part of this patch.
Good idea,
RKSimon added a comment.
Sort of related - should we enable -Wdocumentation (it's currently -Wall and
-Weverything might be too much) on the respective clang builtin tests?
Doesn't have to be part of this patch.
Comment at: lib/Headers/xmmintrin.h:1927
///
-/// This intr
craig.topper added inline comments.
Comment at: lib/Headers/xmmintrin.h:2199
///
-/// This intrinsic corresponds to the VPINSRW / PINSRW instruction.
+/// This intrinsic corresponds to the PINSRW instruction.
///
kromanova wrote:
> craig.topper wrote:
> > W
kromanova added inline comments.
Comment at: lib/Headers/xmmintrin.h:2199
///
-/// This intrinsic corresponds to the VPINSRW / PINSRW instruction.
+/// This intrinsic corresponds to the PINSRW instruction.
///
craig.topper wrote:
> Why is VPINSRW removed?
I
craig.topper added inline comments.
Comment at: lib/Headers/xmmintrin.h:1706
///
-/// This intrinsic corresponds to the VMOVSS / MOVSS + shuffling
+/// This intrinsic corresponds to the VBROADCASTSS / BROADCASTSS
///instruction.
There is no BROADCASTSS
dyung created this revision.
This is the result of several patches we made internally to update the
documentation that we would like to have reviewed for possible submission.
The changes include:
1. Fix inaccurate instruction listings.
2. Fix small issues in _mm_getcsr and _mm_setcsr.
3. Fix de
13 matches
Mail list logo