[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

2017-12-21 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman abandoned this revision. arphaman added a comment. It turns out there's already something that works much better: `#pragma clang __debug handle_crash`. Sorry about the redundant patch! Repository: rC Clang https://reviews.llvm.org/D41526

[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

2017-12-21 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added a comment. Did you consider just using a different pragma that triggers this behaviour instead of avoiding the crash? I don't really have a strong preference but I'd be interested to hear what you think the pros/cons are. Comment at:

[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

2017-12-21 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added a reviewer: benlangmuir. Herald added a subscriber: JDevlieghere. This patch allows libclang to report a parser crash that's caused by `#pragma clang __debug parser_crash` without using the `LLVM_BUILTIN_TRAP`. Instead a new flag in PPOpts is used