This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323196: [clang-tidy] Add -vfsoverlay flag (authored by
ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41535?vs=130891=131046#toc
Repository:
rCTE Clang Tools Extra
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks for adding the test! LGTM, will submit it shortly.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
vladimir.plyashkun updated this revision to Diff 130891.
vladimir.plyashkun added a comment.
Thanks, now all should be fine!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
ilya-biryukov added a comment.
In https://reviews.llvm.org/D41535#983435, @vladimir.plyashkun wrote:
> IIUC, it will be little bit difficult to test it, because whole logic placed
> in the `ClangTidyMain`.
> All existing clang-tidy unit tests use direct calls of `ToolInvocation`
> which is
vladimir.plyashkun added a comment.
In https://reviews.llvm.org/D41535#981928, @ilya-biryukov wrote:
> This looks good, but we should add a test.
> Should've noticed that before, sorry for the slowing this down a bit more.
> After the test is there, I'm happy to commit this change for you.
ilya-biryukov added a comment.
This looks good, but we should add a test.
Should've noticed that before, sorry for the slowing this down a bit more.
After the test is there, I'm happy to commit this change for you.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
vladimir.plyashkun updated this revision to Diff 130589.
vladimir.plyashkun added a comment.
Some more nits were fixed.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
Index:
ilya-biryukov added a comment.
Just a few more NITs and we're good to go
Comment at: clang-tidy/tool/ClangTidyMain.cpp:347
+llvm::errs() << "Error: virtual filesystem overlay file '" << OverlayFile
+ << "' not found.\n";
+return nullptr;
vladimir.plyashkun updated this revision to Diff 130578.
vladimir.plyashkun added a comment.
Fixed code review remarks.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
Index:
ilya-biryukov requested changes to this revision.
ilya-biryukov added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:345
+ if (!Buffer) {
+llvm::errs() << diag::err_missing_vfs_overlay_file << OverlayFile;
+
vladimir.plyashkun updated this revision to Diff 130385.
vladimir.plyashkun added a comment.
Moved logic to `ClangTidyMain`
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
Sorry for the delay
Comment at: clang-tidy/ClangTidy.cpp:93
+vfs::OverlayFileSystem ) {
+ if (OverlayFile.empty())
+
vladimir.plyashkun added a comment.
Friendly ping
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vladimir.plyashkun added a comment.
Second part here (provided default virtual filesystem argument to ClangTool
constructor): https://reviews.llvm.org/D41947
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
___
cfe-commits
vladimir.plyashkun updated this revision to Diff 129440.
vladimir.plyashkun added a reviewer: ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/ClangTidyOptions.cpp
ilya-biryukov added a comment.
In https://reviews.llvm.org/D41535#963859, @vladimir.plyashkun wrote:
> Unfortunately, `-ivfsoverlay` in the compile commands works for the compiler
> invocation, but it doesn't work for tooling.
This looks like a bug in tooling, but let's wait for responses on
vladimir.plyashkun added a comment.
FYI, i've create revision to support `ivfsoverlay` option in Tooling:
https://reviews.llvm.org/D41594
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
___
cfe-commits mailing list
vladimir.plyashkun added a comment.
@ilya-biryukov
Yes, this is exactly what i need.
Unfortunately, `-ivfsoverlay` in the compile commands works for the compiler
invocation, but it doesn't work for tooling.
E.g. this call:
clang-tidy -checks=* -- -ivfsoverlay=
has no effect.
Repository:
ilya-biryukov added a comment.
IIUC, you want to pass an overlay so that clang-tidy will read the file opened
in the IDE from a different directory?
Could you provide add `-ivfsoverlay` option to your compile command instead?
$ clang --help | grep vfs
-ivfsoverlay Overlay the virtual
vladimir.plyashkun added a comment.
Second part of review - https://reviews.llvm.org/D41536
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vladimir.plyashkun created this revision.
vladimir.plyashkun added reviewers: alexfh, benlangmuir.
vladimir.plyashkun added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
These changes introduce support for -vfsoverlay option in Clang-Tidy
The main reason for it:
In IDE
21 matches
Mail list logo
