hans added a comment.
In https://reviews.llvm.org/D41538#969207, @xazax.hun wrote:
> In https://reviews.llvm.org/D41538#969205, @sylvestre.ledru wrote:
>
> > It missed the 6.0 branching. Will you try to get it on this branch?
> > Thanks
>
>
> Sure! I will try to do so: https://reviews.llvm.org/rC
xazax.hun added a comment.
In https://reviews.llvm.org/D41538#969205, @sylvestre.ledru wrote:
> It missed the 6.0 branching. Will you try to get it on this branch?
> Thanks
Sure! I will try to do so: https://reviews.llvm.org/rC321933
Repository:
rC Clang
https://reviews.llvm.org/D41538
sylvestre.ledru added a comment.
It missed the 6.0 branching. Will you try to get it on this branch?
Thanks
Repository:
rC Clang
https://reviews.llvm.org/D41538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321933: [analyzer] Fix some check's output plist not
containing the check name (authored by xazax, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41538?vs=128630&id=128845#toc
Repos
NoQ accepted this revision.
NoQ added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/StaticAnalyzer/Core/BugReporter/BugType.h:51
StringRef getCategory() const { return Category; }
- StringRef getCheckName() const { return Check.ge
xazax.hun added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/BugReporter/BugType.h:51
StringRef getCategory() const { return Category; }
- StringRef getCheckName() const { return Check.getName(); }
+ StringRef getCheckName() const {
+// FIXME: This is a
xazax.hun updated this revision to Diff 128630.
xazax.hun marked an inline comment as done.
xazax.hun added a comment.
- Address some review comments.
https://reviews.llvm.org/D41538
Files:
include/clang/StaticAnalyzer/Core/BugReporter/BugType.h
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
NoQ added a comment.
I'm still not quite sure what's the whole point of having `BugType` without a
checker. We can still easily write anything we want in the "category" and
"name" fields anyways, so we can easily produce bugs that are indistinguishable
to the user from different checkers, while
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:277
+ BT_leakedvalist.reset(new BugType(
+ CheckNames[ReportUninit ? CK_Uninitialized : CK_Unterminated],
+ "Leaked va_list", categories::MemoryError));
-
xazax.hun updated this revision to Diff 128240.
xazax.hun marked 5 inline comments as done.
xazax.hun added a comment.
- Address review comments.
https://reviews.llvm.org/D41538
Files:
include/clang/StaticAnalyzer/Core/BugReporter/BugType.h
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
li
xazax.hun added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/BugReporter/BugType.h:54
+// initialization.
+if (getCheckName().empty() && Checker) {
+ Check = Checker->getCheckName();
a.sidorin wrote:
> Possibly I am missing the cont
a.sidorin added a comment.
Hello Gabor,
For me, this patch looks much better than previous. I have some questions
inline.
Comment at: include/clang/StaticAnalyzer/Core/BugReporter/BugType.h:40
public:
- BugType(class CheckName check, StringRef name, StringRef cat)
- :
xazax.hun created this revision.
xazax.hun added reviewers: NoQ, dcoughlin, george.karpenkov.
Herald added subscribers: dkrupp, a.sidorin, rnkovacs, szepet,
baloghadamsoftware, whisperity.
Unfortunately, currently, the analyzer core sets the checker name after the
constructor was already run. So
13 matches
Mail list logo
