[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

vlad.tsyrklevich added a comment. I noticed in Decl.cpp your change deleted some whitespace that belonged there. Not a big deal, just try to remember to run clang-format-diff when you're submitting for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz closed this revision. saar.raz added a comment. Committed ffa214ef22892d75340dc6720271863901dc2c90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://revi

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaOverload.cpp:594 }; + struct CNSInfo { +TemplateArgumentList *TemplateArgs; Please add a documentation comment.

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 225418. saar.raz added a comment. Address CR comments by rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: clang/include/clang/AST/ASTConcept.h clang/

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

thakis added a comment. reverted in r374985, it wasn't obvious to me how to unbreak the test. Sorry! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 ___ cfe-commits mailing li

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

thakis added a comment. The mangling test fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/15944 It also fails on ppc64le: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/21092 Please watch http://lab.llvm.org:8011/console for a bit after landing c

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

rsmith added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:4127 + + case Expr::ConceptSpecializationExprClass: { +// ::= L E # external name These mangling changes look like they could be separated out from the rest of the patch. These plus the

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 209695. saar.raz added a comment. Move ConstraintSatisfaction to ASTConcept.h Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: include/clang/AST/ASTConcept.h include/clang/

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 209689. saar.raz added a comment. Create ASTConstraintSatisfaction for correctly storing constraint satisfaction data in AST nodes, add support for mangling of ConceptSpecializtationExprs Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 207209. saar.raz added a comment. Herald added subscribers: erik.pilkington, mgorny. Create ASTConstraintSatisfaction for correctly storing constraint satisfaction data in AST nodes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 204782. saar.raz added a comment. Add support for CSE mangling Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSe

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 196091. saar.raz added a comment. Adjusted to changes in getAssociatedConstraints interface Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h inc

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 195009. saar.raz added a comment. Rebase onto trunk Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 161348. saar.raz added a comment. - Adjusted to new CodeSynthesisContexts, added tests for them. Repository: rC Clang https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 159242. saar.raz added a comment. Herald added a subscriber: jfb. - Adjusted to switch to ASTTemplateArgumentList Repository: rC Clang https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td in

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 141248. saar.raz added a comment. Adjusted to piecewise substitution. - Constraint satisfaction will no longer happen for depenent CSEs (was originally needed for normalization, but not worth the trouble with the new piecewise substitution and the fact tha

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 138509. saar.raz added a comment. Fixed another SpecializedConcept reference to NamedConcept. Repository: rC Clang https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sem

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 138505. saar.raz added a comment. Fixed SpecializedConcept reference to NamedConcept. Repository: rC Clang https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h in

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 138501. saar.raz added a comment. Adjusted to changes in https://reviews.llvm.org/D41217 Repository: rC Clang https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h