This revision was automatically updated to reflect the committed changes.
Closed by commit rL321480: [x86][icelake][vpclmulqdq] (authored by coby,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41573?vs=128183&id=128210#toc
Repository:
rL LLVM
https://reviews.llvm.org/D4
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
coby updated this revision to Diff 128183.
coby added a comment.
turning off pclmul forbids enabling vpclmulqdq
Repository:
rC Clang
https://reviews.llvm.org/D41573
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/
coby added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:577
} else if (Name == "pclmul") {
if (Enabled)
setSSELevel(Features, SSE2, Enabled);
craig.topper wrote:
> I think we should disable vpclmulqdq when pclmul is being disabled.
agreed
craig.topper requested changes to this revision.
craig.topper added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Basic/Targets/X86.cpp:577
} else if (Name == "pclmul") {
if (Enabled)
setSSELevel(Features, SSE2, Enabled);
-
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
coby updated this revision to Diff 128139.
coby added a comment.
removing guards to allow better diags
Repository:
rC Clang
https://reviews.llvm.org/D41573
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
l
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for vpclmulqdq instructions, matching a similar work
on the backend (https://reviews.llvm.org/D40101)
Repository:
rC Clang
https://reviews.llvm.org/D41573
Files:
in
