This revision was automatically updated to reflect the committed changes.
Closed by commit rC321477: [x86][icelake][gfni] (authored by coby, committed by
).
Changed prior to commit:
https://reviews.llvm.org/D41582?vs=128168=128207#toc
Repository:
rC Clang
https://reviews.llvm.org/D41582
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
craig.topper added inline comments.
Comment at: test/CodeGen/gfni-builtins.c:45
+
+#ifdef AVX512
+__m512i test_mm512_gf2p8affineinv_epi64_epi8(__m512i A, __m512i B) {
craig.topper wrote:
> Doesn't the define have underscores around it?
Oh its your own define.
craig.topper added inline comments.
Comment at: test/CodeGen/gfni-builtins.c:45
+
+#ifdef AVX512
+__m512i test_mm512_gf2p8affineinv_epi64_epi8(__m512i A, __m512i B) {
Doesn't the define have underscores around it?
Repository:
rC Clang
coby updated this revision to Diff 128168.
coby added a comment.
add forgotten undef[s]
Repository:
rC Clang
https://reviews.llvm.org/D41582
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for gfni instructions, matching a similar work on the
backend (https://reviews.llvm.org/D40373)
Repository:
rC Clang
https://reviews.llvm.org/D41582
Files:
