rsmith closed this revision.
rsmith added a comment.
Committed as r321834.
Repository:
rC Clang
https://reviews.llvm.org/D41736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: include/clang/AST/Attr.h:142
+ /// explicitly provided in the current declaration?
+ bool isInheritEvenIfAlreadyPresent() const {
erichkeane added a comment.
LGTM, I like the shouldInheritEvenIfAlreadyPresent name better than
isInherited... FWIW. I'll let @aaron.ballman make the final call though.
Repository:
rC Clang
https://reviews.llvm.org/D41736
___
cfe-commits mailin
rsmith added a comment.
In https://reviews.llvm.org/D41736#967552, @aaron.ballman wrote:
> I don't suppose there is a chance at test coverage for this change?
Added Erich's test, plus a test that all instances of another attribute
(`annotate`) get instantiated (the latter test failed prior to
rsmith updated this revision to Diff 128654.
Herald added a subscriber: javed.absar.
Repository:
rC Clang
https://reviews.llvm.org/D41736
Files:
include/clang/AST/Attr.h
include/clang/Basic/Attr.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaTemplateInstantiateDecl.cpp
test/SemaTemplate/attri
aaron.ballman added a comment.
I don't suppose there is a chance at test coverage for this change?
Comment at: include/clang/AST/Attr.h:142
+ /// explicitly provided in the current declaration?
+ bool isInheritEvenIfAlreadyPresent() const {
+return InheritEvenIfAlreadyPre
erichkeane added a comment.
Presumably this didn't break any tests, so I'm Ok with it. The initial patch
was to make sure that template specializations could clear certain attributes,
so I think this properly gets that done. The below test was apparently missed
in the initial patch (and was t
rsmith created this revision.
rsmith added reviewers: aaron.ballman, erichkeane.
rsmith added a project: clang.
Herald added a subscriber: sanjoy.
Attribute instantiation would previously default to instantiating each kind of
attribute only once. This was overridden by a flag whose intended purpo
