BillyONeal accepted this revision.
BillyONeal added a comment.
This revision is now accepted and ready to land.
It actually looks like I accidentally committed this back in January so I'm
going to close this :)
https://reviews.llvm.org/D41748
___
c
BillyONeal added a comment.
@EricWF / @mclow.lists Any chance you could take a look sometime soon?
https://reviews.llvm.org/D41748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CaseyCarter added inline comments.
Comment at:
test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exclusive_scan_init_bop_uop.pass.cpp:33
+template
+constexpr auto operator()(T x) const noexcept {
+return static_cast(x + 10);
Altho
BillyONeal added a comment.
> I hate your compiler.
Seems like a valid warning to me :)
Changed predicate to one that adds 10 to each input.
https://reviews.llvm.org/D41748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
BillyONeal updated this revision to Diff 128836.
BillyONeal marked 3 inline comments as done.
BillyONeal added a comment.
Also change predicate from identity to add_ten.
https://reviews.llvm.org/D41748
Files:
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp
test/std/nume
mclow.lists added a comment.
> The use of iota targeting vector with an int parameter
> triggers warnings on MSVC++ assigning an into a unsigned char&
I hate your compiler.
Other than that (and the bit about identity), this looks fine to me.
Comment at:
test/std/numerics/nu
CaseyCarter added inline comments.
Comment at:
test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exclusive_scan_init_bop_uop.pass.cpp:31
-template
-struct identity : std::unary_function
-{
-constexpr const T& operator()(const T& x) const { return x;}
-};
-
BillyONeal created this revision.
BillyONeal added reviewers: mclow.lists, EricWF.
- These tests use function objects from functional, back_inserter from
iterator, and equal from algorithm, so add those headers.
- The use of iota targeting vector with an int parameter
triggers warnings on MSVC++
