This revision was automatically updated to reflect the committed changes.
Closed by commit rL323906: [demangler] Improve variadic template support
(authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41885?vs=131535&id=1
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM once you clean up the `#if 0`.
Comment at: src/cxa_demangle.cpp:260-261
+
+#if 0
+ void dump() const {
+char *Buffer = static_cast(std::malloc(1024));
-
erik.pilkington added inline comments.
Comment at: src/cxa_demangle.cpp:260-261
+
+#if 0
+ void dump() const {
+char *Buffer = static_cast(std::malloc(1024));
dexonsmith wrote:
> Why is this behind `#if 0`? Should you just use something like
> `LLVM_DUMP_M
erik.pilkington updated this revision to Diff 131535.
erik.pilkington marked 2 inline comments as done.
erik.pilkington added a comment.
In this new patch:
- Make the cached values use a 3-way bool type, and default it to false. This
simplifies all the Node ctors.
- Remove some minor style fixes
dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.
Thanks for working on this!
Comment at: src/cxa_demangle.cpp:260-261
+
+#if 0
+ void dump() const {
+char *Buffer = static_cast(std::malloc(1024));
---
erik.pilkington added a comment.
Ping!
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added inline comments.
Comment at: src/cxa_demangle.cpp:130
- // Offset of position in buffer, used for building stream_string_view.
- typedef unsigned StreamPosition;
-
This caching API is being removed because it is no longer valid: if a node
erik.pilkington created this revision.
erik.pilkington added reviewers: EricWF, mclow.lists, dexonsmith.
This patch fixes some longstanding bugs in the demangler to do with it's
handling of variadic templates.
Currently the demangler handles variadic templates by expanding them into the
Names s
