This revision was automatically updated to reflect the committed changes.
Closed by commit rL322690: [Format] Improve ObjC header guessing heuristic
(authored by benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42135
Files:
benhamilton updated this revision to Diff 130202.
benhamilton added a comment.
Use unordered_set, consolidate at-token checks
Repository:
rC Clang
https://reviews.llvm.org/D42135
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
benhamilton updated this revision to Diff 130192.
benhamilton added a comment.
- Remove unused variable.
Repository:
rC Clang
https://reviews.llvm.org/D42135
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
=
benhamilton updated this revision to Diff 130044.
benhamilton added a comment.
- Last cleanup for tests
Repository:
rC Clang
https://reviews.llvm.org/D42135
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
==
benhamilton updated this revision to Diff 130042.
benhamilton added a comment.
- Tidy up
Repository:
rC Clang
https://reviews.llvm.org/D42135
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
=
benhamilton updated this revision to Diff 130041.
benhamilton added a comment.
- Move tests to FormatTestObjC.cpp
Repository:
rC Clang
https://reviews.llvm.org/D42135
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
benhamilton created this revision.
benhamilton added reviewers: jolesiak, krasimir.
Herald added subscribers: cfe-commits, klimek.
This improves upon the previous Objective-C header guessing heuristic
from https://reviews.llvm.org/rC320479.
Now, we run the lexer on C++ header files and look for O
