This revision was automatically updated to reflect the committed changes.
Closed by commit rC323577: Always allow #pragma region. (authored
by mattd, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42248
Files:
lib/Lex/Pragma.cpp
test/Frontend/region-pragmas.c
Index:
mattd added a comment.
Thanks @majnemer! Would you mind committing this on my behalf? I do not have
commit access, thanks.
https://reviews.llvm.org/D42248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D42248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Quuxplusone added a comment.
FWIW, I would also like this patch, because it would mean that I could build
with -Werror even when the project includes headers written by MSVC-using
people. Given that we know what "#pragma region" does, it hardly deserves an
"unknown pragma" diagnostic! So this
mattd added a comment.
Ping.
https://reviews.llvm.org/D42248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mattd updated this revision to Diff 130523.
mattd retitled this revision from "[LangOpts] Add a LangOpt to represent
"#pragma region" support." to "Always allow "#pragma region".".
mattd edited the summary of this revision.
mattd added a comment.
I'm certainly fine with always allowing this
