benhamilton added a comment.
Thanks, fixed.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.h:38
const std::vector SpecialAcronyms;
+const std::vector AdditionalAcronyms;
};
hokein wrote:
> nit: code indent
Ah, the previous one was wrong, I see.
benhamilton updated this revision to Diff 130657.
benhamilton marked 2 inline comments as done.
benhamilton added a comment.
- Switch to IncludeDefaultAcronyms option (defaults to 1).
- Use array for default acronyms, since we no longer need to parse it.
- Don't regex-escape default acronyms, sinc
hokein added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.h:38
const std::vector SpecialAcronyms;
+const std::vector AdditionalAcronyms;
};
nit: code indent
Comment at: docs/clang-tidy/checks/objc-property-dec
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/objc-property-declaration.rst:45
+
+ If set, replaces the default list. (If you want to append to the default
list, set AdditionalAcronyms instead.)
+
Please limit string length to 80 sym
benhamilton created this revision.
benhamilton added reviewers: Wizard, hokein, klimek.
Herald added a subscriber: cfe-commits.
The existing option objc-property-declaration.Acronyms
replaces the built-in set of acronyms.
While this behavior is OK for clients that don't want the default
behavior,