EricWF closed this revision.
EricWF added a comment.
Committed as r324799.
Thank you!
https://reviews.llvm.org/D42344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ng added a comment.
Could you please commit this on my behalf? I don't have commit access.
https://reviews.llvm.org/D42344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
This LGTM.
https://reviews.llvm.org/D42344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ng added a comment.
Ping
https://reviews.llvm.org/D42344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ng updated this revision to Diff 130817.
ng added a comment.
Fix multiset variable definition in tests
https://reviews.llvm.org/D42344
Files:
libcxx/include/map
libcxx/include/set
libcxx/test/std/containers/associative/map/map.ops/count_transparent.pass.cpp
mclow.lists added a comment.
In https://reviews.llvm.org/D42344#983265, @ng wrote:
> In https://reviews.llvm.org/D42344#983264, @mclow.lists wrote:
>
> > Shouldn't there be tests for `multimap` and `multiset`, too?
>
>
> Sure; will the same tests as for map/set be alright?
Actually, I think
ng added a comment.
In https://reviews.llvm.org/D42344#983264, @mclow.lists wrote:
> Shouldn't there be tests for `multimap` and `multiset`, too?
Sure; will the same tests as for map/set be alright?
https://reviews.llvm.org/D42344
___
mclow.lists added a comment.
Sometimes you get lucky ;-)
I have a task for next week that says "The transparent lookup stuff in the
associative containers needs tests", and here is this patch.
Instead of "transparent_count.pass.cpp", please name the test
"count_transparent.pass.cpp" so it will
ng updated this revision to Diff 130812.
ng added a comment.
As per the above suggestions, enabled _multi tree search only for transparent
comparator functions, and added tests.
https://reviews.llvm.org/D42344
Files:
libcxx/include/map
libcxx/include/set
EricWF added a comment.
@rsmith Yes. I agree this should only be applied in that case
Repository:
rCXX libc++
https://reviews.llvm.org/D42344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith added a comment.
Shouldn't we be changing only the heterogeneous functions here?
Repository:
rCXX libc++
https://reviews.llvm.org/D42344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
Could you provide tests that demonstrate the previously incorrect behavior?
Repository:
rCXX libc++
https://reviews.llvm.org/D42344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ng created this revision.
ng added a reviewer: mclow.lists.
Herald added a reviewer: EricWF.
As described in http://bugs.llvm.org/show_bug.cgi?id=30959, the current
implementation of std::{map, key}::{count, equal_range} in libcxx is
non-conforming. Quoting ISO/IEC 14882:2014 section 23.2.4:
>
13 matches
Mail list logo