[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-02-11 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF closed this revision. EricWF added a comment. Committed as r324853. Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-28 Thread Force.Charlie-I via Phabricator via cfe-commits
fcharlie added a comment. @compnerd Please commit this, Thanks Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-28 Thread Force.Charlie-I via Phabricator via cfe-commits
fcharlie accepted this revision. fcharlie added a comment. libcxx: Fix libcxx MSVC C++17 redefinition of 'align_val_t' Differential Revision: https://reviews.llvm.org/D42354 Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-27 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. I think that if we can remove the `__zero` and `__max`, we should do that, but that is better done as a separate change. Repository: rCXX libc++ https://reviews.llvm.org/D42354

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-25 Thread Force.Charlie-I via Phabricator via cfe-commits
fcharlie added a comment. In https://reviews.llvm.org/D42354#988656, @mclow.lists wrote: > I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t` > in *that* header file. > > Now I'm wondering if those values `__zero` and `__max` are actually used. Use > grep

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-25 Thread Force.Charlie-I via Phabricator via cfe-commits
fcharlie added a comment. In https://reviews.llvm.org/D42354#988656, @mclow.lists wrote: > I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t` > in *that* header file. > > Now I'm wondering if those values `__zero` and `__max` are actually used. Use > grep

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-25 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t` in *that* header file. Now I'm wondering if those values `__zero` and `__max` are actually used. Repository: rCXX libc++ https://reviews.llvm.org/D42354

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-22 Thread Force.Charlie-I via Phabricator via cfe-commits
fcharlie added a comment. In https://reviews.llvm.org/D42354#984067, @STL_MSFT wrote: > Seems reasonable to me. Thanks Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-22 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. Seems reasonable to me. Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-22 Thread Force.Charlie-I via Phabricator via cfe-commits
fcharlie updated this revision to Diff 130871. https://reviews.llvm.org/D42354 Files: include/new Index: include/new === --- include/new +++ include/new @@ -160,6 +160,7 @@ #endif // defined(_LIBCPP_BUILDING_NEW) ||

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-21 Thread Force.Charlie-I via Phabricator via cfe-commits
fcharlie created this revision. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. When use clang-cl -std:c++17 -Iinclude\c++\v1 hello.cc c++.lib In file included from hello.cc:1: In file included from include\c++\v1\iostream:38: In file included from