[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

ldionne added a comment. I proposed a revert here for those who are interested: https://reviews.llvm.org/D91099 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42459/new/ https://reviews.llvm.org/D42459 ___ cfe-commits

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

ldionne added a comment. In D42459#2383794 , @hintonda wrote: > In D42459#2383753 , @ldionne wrote: > >> @hintonda Is there a reason why this was done except for "standardizing the >> usage across projects"? > >

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda added a comment. In D42459#2383753 , @ldionne wrote: > @hintonda Is there a reason why this was done except for "standardizing the > usage across projects"? It was just for standardization. Please feel free to rollback or modify as

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

ldionne added a comment. @hintonda Is there a reason why this was done except for "standardizing the usage across projects"? I'm asking because this change prevents us from being able to avoid having a rpath completely when building libc++. That is the behavior we want when building libc++

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323492: Reland: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed by

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323492: Reland: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda updated this revision to Diff 131506. hintonda added a comment. Only call llvm_setup_rpath() if LLVM_FOUND is true. Repository: rCXX libc++ https://reviews.llvm.org/D42459 Files: lib/CMakeLists.txt Index: lib/CMakeLists.txt

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda requested review of this revision. hintonda added a comment. I probably should have put this in the summary, but the reason for this patch isn't just to clean up the cmake files, it's to fix a cmake configuration failure when cross-compiling for Linux on Darwin: CMake Error at

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. Reopen after rollback. @smeenai pointed out LLVM may not be available in standalone builds Repository: rCXX libc++ https://reviews.llvm.org/D42459

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323453: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42459?vs=131195=131478#toc