[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

This revision was automatically updated to reflect the committed changes. Closed by commit rL323425: [clangd] Provide a helper to report estimated memory usage per-file (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323425: [clangd] Provide a helper to report estimated memory usage per-file (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D42480?vs=131435=131438#toc

[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

ilya-biryukov updated this revision to Diff 131435. ilya-biryukov marked 6 inline comments as done. ilya-biryukov added a comment. - Added a FIXME to CppFile::getUsedBytes() Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42480 Files: clangd/ClangdServer.cpp

[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

ilya-biryukov added a comment. Thanks for reviewing this! Comment at: unittests/clangd/ClangdTests.cpp:428 +TEST_F(ClangdVFSTest, MemoryUsage) { + MockFSProvider FS; ioeric wrote: > ilya-biryukov wrote: > > ioeric wrote: > > > Can we add a test for

[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg Comment at: clangd/ClangdUnit.cpp:664 + std::lock_guard Lock(Mutex); + return ASTMemUsage + PreambleMemUsage; +} ilya-biryukov wrote: > ioeric wrote: >

[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:324 + /// Returns estimated memory usage for each of the currently files. + /// The order of results is unspecified. ioeric wrote: >

[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

ilya-biryukov updated this revision to Diff 131415. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Fixed review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42480 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

ioeric added inline comments. Comment at: clangd/ClangdServer.h:324 + /// Returns estimated memory usage for each of the currently files. + /// The order of results is unspecified. s/currently/current/ ? or current open? Comment at:

[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric, hokein. Herald added subscribers: jkorous-apple, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42480 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp