[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324469: [clang-format] Fix ObjC message arguments formatting. (authored by jolesiak, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42493 Files:

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

jolesiak updated this revision to Diff 131943. jolesiak added a comment. - Add test Repository: rC Clang https://reviews.llvm.org/D42493 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index: unitt

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

krasimir added inline comments. Comment at: unittests/Format/FormatTestObjC.cpp:678 + " a = 42;\n" + "}\n" + "secondBlock:^{\n" Can you put a test with a non-block between two blocks please Repository: rC

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

benhamilton accepted this revision. benhamilton added a comment. shipit Repository: rC Clang https://reviews.llvm.org/D42493 ___ cfe-commits mailing

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

jolesiak updated this revision to Diff 131825. jolesiak added a comment. - Add comment explaining ParameterCount reset. Repository: rC Clang https://reviews.llvm.org/D42493 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/For

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:419 StartsObjCMethodExpr = true; + Left->ParameterCount = 0; Contexts.back().ColonIsObjCMethodExpr = true; jolesiak wrote: > benhamilton wrote: > > What do

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

jolesiak added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:419 StartsObjCMethodExpr = true; + Left->ParameterCount = 0; Contexts.back().ColonIsObjCMethodExpr = true; benhamilton wrote: > What does this line do? Seems

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/TokenAnnotator.cpp:419 StartsObjCMethodExpr = true; + Left->ParameterCount = 0; Contexts.back().ColonIsObj

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

jolesiak created this revision. Herald added subscribers: cfe-commits, klimek. jolesiak edited the summary of this revision. Fixes formatting of ObjC message arguments when inline block is a first argument. Having inline block as a first when method has multiple parameters is discouraged by Apple