compnerd closed this revision.
compnerd added a comment.
SVN r323547
Repository:
rC Clang
https://reviews.llvm.org/D42508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D42508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
compnerd updated this revision to Diff 131477.
compnerd added a comment.
Add additional test cases as discussed on IRC. These ensure that the back
reference handling is correct.
Repository:
rC Clang
https://reviews.llvm.org/D42508
Files:
lib/AST/MicrosoftMangle.cpp
compnerd updated this revision to Diff 131379.
compnerd marked an inline comment as done.
compnerd added a comment.
scope the template back references and add a comment.
https://reviews.llvm.org/D42508
Files:
lib/AST/MicrosoftMangle.cpp
test/CodeGenObjCXX/msabi-protocol-conformance.mm
rjmccall added a comment.
The basic idea here seems fine to me; I'll leave David to review the details.
Repository:
rC Clang
https://reviews.llvm.org/D42508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:2459-2465
+ if (T->isObjCId())
+mangleSourceName("objc_object");
+ else if (T->isObjCClass())
+mangleSourceName("objc_class");
+ else
+mangleSourceName(T->getInterface()->getName());
+
compnerd created this revision.
compnerd added reviewers: rjmccall, rnk.
Herald added a subscriber: cfe-commits.
Add support for mangling ObjC protocol conformances in MS ABI as if they are
COM interfaces. By diverging from the itanium mangling of `objc_protocol`
prefixed names, this approach
