sammccall added a comment.
r323443 removed ScopeExitGuard altogether.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov added inline comments.
Comment at: clangd/Function.h:141
namespace detail {
+/// Optional-like type that sets its value to llvm::None when it was moved
+/// constructed from.
sammccall wrote:
> As noted in the thread I don't think this pulls its
sammccall added inline comments.
Comment at: clangd/Function.h:141
namespace detail {
+/// Optional-like type that sets its value to llvm::None when it was moved
+/// constructed from.
As noted in the thread I don't think this pulls its weight for us.
Swapping
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, klimek.
r322838 changed semantics for llvm::Optional that removes the
guarantee of setting the value to empty after move.
This change creates a wrapper around Optional
