[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

krytarowski added a comment. This looks like broke ASan on NetBSD: $ sh ./projects/compiler-rt/test/sanitizer_common/asan-i386-NetBSD/NetBSD/Output/ttyent.cc.script /usr/lib/i386/libgcc.a(unwind-dw2.o): In function `_Unwind_RaiseException': unwind-dw2.c:(.text+0x1b41): multiple definition

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT326132: [asan] Intercept std::rethrow_exception indirectly (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42644?vs=132990=135965#toc Repository: rCRT

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka added inline comments. Comment at: test/asan/TestCases/intercept-rethrow-exception.cc:48 + // memcpy is intercepted by asan which performs checks on src and dst + using T = int[1000]; + T x {}; robot wrote: > vitalybuka wrote: > > You can include

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot added inline comments. Comment at: test/asan/TestCases/intercept-rethrow-exception.cc:48 + // memcpy is intercepted by asan which performs checks on src and dst + using T = int[1000]; + T x {}; vitalybuka wrote: > You can include #include > and use

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: test/asan/TestCases/intercept-rethrow-exception.cc:48 + // memcpy is intercepted by asan which performs checks on src and dst + using T =

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot marked an inline comment as done. robot added a comment. Have you had the time to review the second revision? Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot updated this revision to Diff 132990. robot added a comment. - Reformatted using clang-format - Fixed copy error CHECK(REAL(__cxa_throw)) - moved test from asan unit test to lit tests Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 Files:

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka added a comment. I would not worry about cross platform here. You can patch just Linux and whoever have access (and issues) on other platforms can send a patch with similar changes. Mac should use libc++. I'd put the test outside of Posix, and mark failing platforms as "// XFAIL:",

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka added a comment. Could you please reformat it? With git I usually use: git clang-format -f --style=file HEAD^ Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

kubamracek added a comment. > This is our first patch so we're unfamiliar with the LLVM testing > infrastructure. Could you please tell us what kind of test you'd like? An > example would also be great. Thank you for your first contribution! I'm going to comment on the testing infrastructure

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot added a comment. In https://reviews.llvm.org/D42644#993506, @kubamracek wrote: > Cool. Can we get a lit test as well? This is our first patch so we're unfamiliar with the LLVM testing infrastructure. Could you please tell us what kind of test you'd like? An example would also be great.

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

kubamracek added a comment. Cool. Can we get a lit test as well? Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot created this revision. robot added a reviewer: cryptoad. robot added a project: Sanitizers. Herald added subscribers: Sanitizers, llvm-commits, hintonda, mgorny, kubamracek. Fixes Bug 32434 See https://bugs.llvm.org/show_bug.cgi?id=32434 Short summary: std::rethrow_exception does not use