stephanemoore added a comment.
Thanks for the explanation 👌 I'm still learning the inner workings of clang 😅
The change looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D42704
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324618: [clang-format] Do not break Objective-C string
literals inside array literals (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42704?vs=132031&id=1334
benhamilton added a comment.
@stephanemoore: It appears all warnings are enabled by default unless they are
in class `DefaultIgnore`:
https://github.com/llvm-mirror/clang/blob/6de2efd1953adaa9a190b2cdfbe7b5c15f6d6efe/include/clang/Basic/Diagnostic.td#L105
This diagnostic is not in `DefaultIgnor
stephanemoore added a comment.
The summary states that -Wobjc-string-concatenation is enabled by default? I
looked through `include/clang/Basic/DiagnosticGroups.td` and did not see
evidence that `ObjCStringConcatenation` is under `All`. Am I missing something?
Is -Wobjc-string-concatenation ena
benhamilton added a comment.
Ping ping!
Repository:
rC Clang
https://reviews.llvm.org/D42704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benhamilton added a comment.
Ping! Any comments?
Repository:
rC Clang
https://reviews.llvm.org/D42704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benhamilton created this revision.
benhamilton added reviewers: jolesiak, stephanemoore, djasper.
Herald added subscribers: cfe-commits, klimek.
Concatenating Objective-C string literals inside an array literal
raises the warning -Wobjc-string-concatenation (which is enabled by default).
clang-fo
