Re: [PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

2018-02-06 Thread Ilya Biryukov via cfe-commits
It probably tries doing a standalone build of clang without LLVM. clang/config.h doesn't seem to include the HAVE_PTHREAD_GETSPECIFIC used in Context.cpp. We can either add the corresponding macro to clang's config.h or follow jyknight's suggestions and figure out if we can remove pthread-specific

[PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

2018-02-06 Thread Mike Lothian via Phabricator via cfe-commits
FireBurn added a comment. This breaks compilation for me on Gentoo's clang-.ebuild The following patch fixes things for me commit a4c071b16bbbc84bbb96d90b51bed8a12127 (HEAD -> master) Author: Mike Lothian Date: Tue Feb 6 09:55:41 2018 +

[PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

2018-02-01 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. Is there some way to figure out what's going on in clang-x86_64-linux-selfhost-modules? I believe there should be no linux builders which are missing this function -- it was added to libgcc in 4.8, and we don't support older versions, so I think missing this function

[PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

2018-02-01 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323949: [clangd] Use pthread instead of thread_local to support more runtimes. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

2018-02-01 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42742 ___ cfe-commits mailing list

[PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

2018-01-31 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: ilya-biryukov, bkramer. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek. thread_local has nice syntax and semantics, but requires __cxa_thread_atexit, and some not-ancient runtime libraries don't provide it. The