az created this revision.
az added a reviewer: SjoerdMeijer.
Herald added subscribers: hiraditya, kristof.beyls, javed.absar, rengolin,
aemerson.
A couple of fixes on top of https://reviews.llvm.org/D41792:
- Fixes for freceprical, and fsqrt instructions in the backend.
- The intrinsics that gen
SjoerdMeijer added a comment.
Thanks for fixing this. Looks very reasonable to me.
Question about the failures: I am now wondering if this means we were and still
are missing tests?
Nit: for future reviews, I think it is better to split patches up if they are
commits to
different repos.
htt
az updated this revision to Diff 133505.
az added a comment.
> Question about the failures: I am now wondering if this means we were and
> still are missing tests?
Given that this work is fixing https://reviews.llvm.org/D41792 which is mainly
about adding frontend intrinsic support, then there
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Thanks
https://reviews.llvm.org/D42993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
az closed this revision.
az added a comment.
Committed as r324940 and r324912
https://reviews.llvm.org/D42993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
