[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea added a comment. In D43002#3205190 , @MaskRay wrote: > Some test nits:) I don't know CodeView :( Fixed, thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llv

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

MaskRay added a comment. Some test nits:) I don't know CodeView :( Comment at: clang/test/CodeGenCXX/debug-info-objname.cpp:1 +// RUN: cp %s %T/debug-info-objname.cpp +// RUN: cd %T The whole file appears to be CRLF where almost all other tests use LF in llvm-

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf44e3fbadd15: [CodeView] Emit S_OBJNAME record (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D43002?vs=374884&id=395663#

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Sorry for the delay, I got sick last week and read through email newest to oldest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ htt

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea removed a reviewer: deadalnix. aganea added a comment. Ping! Any further comments? Thanks in advance for your time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llvm.org/D43002 ___

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:752 +static void unescapeSlashes(SmallVectorImpl &Str) { + auto Read = Str.begin(); rnk wrote: > aganea wrote: > > rnk wrote: > > > This isn't unescaping them, it's just ca

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea updated this revision to Diff 374884. aganea marked 5 inline comments as done. aganea edited reviewers, added: akhuang; removed: zturner, gratianlup. aganea edited subscribers, added: zturner, gratianlup; removed: aganea. aganea added a comment. Herald added subscribers: dang, mgorny. As su

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

dpaoliello added a comment. Herald added a subscriber: ormris. @rnk @aganea Ping... Just wanted to see what was happening with this change, and if there is anything I can do to help get it merged in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

rnk added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:212 + /// Output filename used in the COFF debug information. + std::string COFFOutputFilename; + aganea wrote: > rnk wrote: > > Let's bikeshed the name a bit. This thing is the `

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea marked 8 inline comments as done. aganea added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:212 + /// Output filename used in the COFF debug information. + std::string COFFOutputFilename; + rnk wrote: > Let's bikeshed the name

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

rnk added a comment. I think the biggest concern here is what to do about `/Fa` / `-save-temps`. If we do nothing, the S_OBJNAME record will change if you run the same compilation twice with and without those flags. Generally, we strive to ensure that the directly emitted object file is identic