This revision was automatically updated to reflect the committed changes.
Closed by commit rL324725: [clangd] Remove threading-related code from
ClangdUnit.h (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43065
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
:-D
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric added inline comments.
Comment at: clangd/ClangdUnit.cpp:399
+ std::unique_ptr CI;
+ {
+// FIXME(ibiryukov): store diagnostics from CommandLine when we start
ilya-biryukov wrote:
> ioeric wrote:
> > Do we still need this block?
> I added it to avoid
ilya-biryukov updated this revision to Diff 133416.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Removed braces
- s/latest/last/
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43065
Files:
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
ilya-biryukov added a comment.
Thanks for the NITs :-)
Comment at: clangd/ClangdUnit.cpp:399
+ std::unique_ptr CI;
+ {
+// FIXME(ibiryukov): store diagnostics from CommandLine when we start
ioeric wrote:
> Do we still need this block?
I added it to avoid
ioeric added a comment.
Nice! The code looks much simpler!
Just some drive-by nits. I don't know the threading work well enough to give
useful comments. Will leave the approval to others.
Comment at: clangd/ClangdUnit.cpp:399
+ std::unique_ptr CI;
+ {
+//
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, hokein, ioeric.
Herald added subscribers: jkorous-apple, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43065
Files:
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
