ilya-biryukov added inline comments.
Comment at: unittests/clangd/SyncAPI.h:1
+//===--- SyncAPI.h - Sync version of ClangdServer's API --*-
C++-*-===//
+//
sammccall wrote:
> Being able to call synchronously is really nice for tests.
> It's a bit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324883: [clangd] Remove codeComplete that returns
std::future (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43068
ilya-biryukov updated this revision to Diff 133825.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
Herald added a subscriber: mgorny.
- Added CaptureProxy helper, use it to implement runCodeComplete.
- Documented that we deliberately don't expose the sync API in
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
One down!
I'd like to know what you think about a generic "block the call and capture the
result" mechanism rather than method-specific wrappers.
But if you're not convinced or just
ioeric added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
ilya-biryukov wrote:
> ioeric wrote:
> >
ilya-biryukov added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
ioeric wrote:
> ilya-biryukov wrote:
> >
ioeric added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
ilya-biryukov wrote:
> ioeric wrote:
> > Any
ilya-biryukov added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
ioeric wrote:
> Any reason not to put
ioeric added inline comments.
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===-===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
Any reason not to put sync APIs in ClangdServer
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, sammccall.
Herald added subscribers: jkorous-apple, klimek.
It was deprecated and callback version and is used everywhere.
Only changes to the testing code were needed.
Repository:
rCTE Clang Tools Extra
10 matches
Mail list logo