This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE324742: [clang-move] Don't dump macro symbols.
(authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43075?vs=133621&id=133623#toc
Repository:
rCTE Clang Tools Ext
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:526
unless(usingDirectiveDecl()), // using namespace decl.
+ notInMacro(),
InOldHeader,
ioeric wrote:
> I'd probably relax the condition a bit; theoretically tools would be able
hokein updated this revision to Diff 133621.
hokein marked an inline comment as done.
hokein added a comment.
Add more tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43075
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clan
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Ooops, forgot to stamp!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43075
___
cfe-commits mailing list
cfe-commits@lists.llvm
ioeric added a comment.
Lg. Thanks for the change!
Comment at: clang-move/ClangMove.cpp:526
unless(usingDirectiveDecl()), // using namespace decl.
+ notInMacro(),
InOldHeader,
I'd probably relax the condition a bit; theoretically tools would
hokein created this revision.
hokein added a reviewer: ioeric.
Herald added a subscriber: klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43075
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp