This revision was automatically updated to reflect the committed changes.
Closed by commit rL325196: AMDGPU: Enable PIC by default for amdgcn (authored
by kzhuravl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
t-tye accepted this revision.
t-tye added a comment.
For now seems reasonable to fix amdgpu as PIC. If/when other clients of amdgpu
have tool chains defined then can switch to controling in the toolchain
isPICDefault() function.
https://reviews.llvm.org/D43094
kzhuravl added a comment.
Ping.
https://reviews.llvm.org/D43094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
msearles accepted this revision.
msearles added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D43094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kzhuravl added a comment.
I thought we could override `isPICDefault` in AMDGPUToolChain instead of doing
what is posted. But AMDGPUToolChain is only created for AMDHSA OS.
Do we want to enable PIC by default for all AMDGCNs? Or only for AMDHSA?
https://reviews.llvm.org/D43094
kzhuravl created this revision.
kzhuravl added reviewers: nhaehnle, t-tye, timcorringham, tpr, tstellar.
Herald added subscribers: dstuttard, yaxunl, wdng.
https://reviews.llvm.org/D43094
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/amdgcn-toolchain-pic.cl
Index:
