[PATCH] D43182: [clangd] SymbolLocation only covers symbol name.

2018-02-13 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324992: [clangd] SymbolLocation only covers symbol name. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D43182?vs=133839&id=134008#toc Repository: rCTE Clang

[PATCH] D43182: [clangd] SymbolLocation only covers symbol name.

2018-02-13 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rL324992: [clangd] SymbolLocation only covers symbol name. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D43182: [clangd] SymbolLocation only covers symbol name.

2018-02-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clangd/index/Index.cpp:40 raw_ostream &operator<<(raw_ostream &OS, const Symbol &S) { - return OS << S.Scope << S.Name; + return OS << S.Scope << S

[PATCH] D43182: [clangd] SymbolLocation only covers symbol name.

2018-02-12 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek. - Change the offset range to half-open, [start, end). - Fix a few fixmes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43182 Files: clan