espindola closed this revision.
espindola added a comment.
325915
https://reviews.llvm.org/D43514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Feb 22, 2018 at 4:40 PM Rafael Avila de Espindola via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Eric Christopher via Phabricator writes:
>
> > echristo added inline comments.
> >
> >
> >
> > Comment at: lib/CodeGen/CodeGenModule.h:728
> > + /// This must be call
Eric Christopher via Phabricator writes:
> echristo added inline comments.
>
>
>
> Comment at: lib/CodeGen/CodeGenModule.h:728
> + /// This must be called after dllimport/dllexport is set.
> + /// FIXME: should this set dllimport/dllexport instead?
>void setGVProperties(llv
echristo added inline comments.
Comment at: lib/CodeGen/CodeGenModule.h:728
+ /// This must be called after dllimport/dllexport is set.
+ /// FIXME: should this set dllimport/dllexport instead?
void setGVProperties(llvm::GlobalValue *GV, const NamedDecl *D) const;
--
espindola updated this revision to Diff 135547.
espindola added a comment.
Address review comments.
https://reviews.llvm.org/D43514
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGen/aarch64-varargs-ms.c
echristo added a comment.
Some inline comments - I think this looks ok in general, but I'm curious about
the answers to the questions/documentation bits inline.
Thanks!
Comment at: lib/CodeGen/CGDecl.cpp:257
+ setGVProperties(GV, &D);
+
If positioning is i
espindola created this revision.
espindola added a reviewer: rnk.
Herald added subscribers: eraman, javed.absar.
With this there are still some GVs where we don't set dso_local because
setGVProperties is never called. I intend to fix that in followup commits. This
is just the bare minimum to tea