[PATCH] D43969: Improve completion experience for headers

2018-03-01 Thread Philipp via Phabricator via cfe-commits
phst created this revision. phst added a reviewer: klimek. Herald added a subscriber: cfe-commits. When calling `completing-read', we should provide a default to prevent the behavior described in https://github.com/DarwinAwardWinner/ido-completing-read-plus#why-does-ret-sometimes-not-select-the-

[PATCH] D43969: Improve completion experience for headers

2018-03-01 Thread Philipp via Phabricator via cfe-commits
phst updated this revision to Diff 136597. phst added a comment. Revert bogus additions Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43969 Files: include-fixer/tool/clang-include-fixer.el Index: include-fixer/tool/clang-include-fixer.el ===

[PATCH] D43969: Improve completion experience for headers

2018-03-01 Thread Philipp via Phabricator via cfe-commits
phst updated this revision to Diff 136598. phst added a comment. Fix condition Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43969 Files: include-fixer/tool/clang-include-fixer.el Index: include-fixer/tool/clang-include-fixer.el

[PATCH] D43969: Improve completion experience for headers

2018-04-09 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D43969: Improve completion experience for headers

2018-04-09 Thread Philipp via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329566: Improve completion experience for headers (authored by phst, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43969 Files: clang-tools-e