This revision was automatically updated to reflect the committed changes.
Closed by commit rC327317: Check that ubsan is the only supported sanitizer on
OpenBSD (authored by vedantk, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327317: Check that ubsan is the only supported sanitizer on
OpenBSD (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4406
devnexen added a comment.
Yes I do ☺ thanks.
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a comment.
The new changes look fine. Do you need someone to commit this for you?
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
ping would be nice if it was commited this week :-) especially the other bits
are already
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
devnexen updated this revision to Diff 137448.
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -388,6 +388,25 @@
// RUN
devnexen updated this revision to Diff 137447.
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -388,6 +388,21 @@
// RUN
krytarowski added a comment.
While there can we add the remaining sanitizers here, like lsan, msan, tsan,
esan etc?
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm provided the bots are happy.
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
devnexen added inline comments.
Comment at: test/Driver/fsanitize.c:392
+// RUN %clang -target i386-pc-openbsd -fsanitize=undefined %s -### 2>&1 |
FileCheck --check-prefix=CHECK_UBSAN-OPENBSD
+// CHECK-UBSAN-OPENBSD: -fsanitize=undefined
+
vsk wrote:
> Why does
devnexen updated this revision to Diff 137284.
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -388,6 +388,12 @@
// RUN
vsk requested changes to this revision.
vsk added inline comments.
This revision now requires changes to proceed.
Comment at: test/Driver/fsanitize.c:392
+// RUN %clang -target i386-pc-openbsd -fsanitize=undefined %s -### 2>&1 |
FileCheck --check-prefix=CHECK_UBSAN-OPENBSD
+// C
davide added a comment.
Apologies, but this is not an area I'm particularly familiar with. So, I'm
resigning, but @filcab / @vsk can probably comment.
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
devnexen updated this revision to Diff 136924.
devnexen added a comment.
Enable UBsan test
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
test/Driver/unknown-arg.c
Index: test/Driver/unknown-arg.c
===
--- test
krytarowski added a comment.
Please mark ubsan as supported now.
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
In https://reviews.llvm.org/D44069#1026563, @krytarowski wrote:
> Revert: http://llvm.org/viewvc/llvm-project?revision=326652&view=revision
>
> And fix.
I launched llvm-lit to the whole directory and this is the fixes.
https://reviews.llvm.org/D44069
_
devnexen updated this revision to Diff 136919.
devnexen added a comment.
- Only Asan is not working under OpenBSD
- unknown-arg test fails under OpenBSD
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
test/Driver/unknown-arg.c
Index: test/Driver/unknown-arg.c
==
krytarowski added a comment.
Revert: http://llvm.org/viewvc/llvm-project?revision=326652&view=revision
And fix.
Repository:
rC Clang
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
devnexen added a comment.
In https://reviews.llvm.org/D44069#1026551, @krytarowski wrote:
> This is not breaking (only?) on OpenBSD, but the triple is breaking all
> tested platforms.
> Please support it properly.
What needs to be done ? I mean I have all OpenBSD compiler-rt code in my side
krytarowski added a comment.
This is not breaking (only?) on OpenBSD, but the triple is breaking all tested
platforms.
Please support it properly.
Repository:
rC Clang
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@list
devnexen created this revision.
devnexen added a reviewer: krytarowski.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
OpenBSD supporting only UBsan unsupported this particular test
Repository:
rC Clang
https://reviews.llvm.org/D44069
Files:
21 matches
Mail list logo