[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-06-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC333941: [CFG] Fix automatic destructors when a member is bound to a reference. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44238 Files: lib/Analysis/CFG.cp

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-05-30 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. I'm not an expert in CFG construction, but looks good to me. https://reviews.llvm.org/D44238 ___ cfe-commits mailing list cfe

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-05-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 147635. NoQ added a comment. Switch to `skipRValueSubobjectAdjustments`. Yup, that's much better. Add FIXME tests for lifetime extension through non-references that are still not working - that correspond to a nearby FIXME in the code. I'm not planning to fix t

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-04-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:1435 /// extended by a local reference with the given initializer. static QualType getReferenceInitTemporaryType(ASTContext &Context, const Expr *Init, rs

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-04-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/Analysis/CFG.cpp:1435 /// extended by a local reference with the given initializer. static QualType getReferenceInitTemporaryType(ASTContext &Context, const Expr *Init,

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-04-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:1435 /// extended by a local reference with the given initializer. static QualType getReferenceInitTemporaryType(ASTContext &Context, const Expr *Init, rs

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-03-31 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/Analysis/CFG.cpp:1435 /// extended by a local reference with the given initializer. static QualType getReferenceInitTemporaryType(ASTContext &Context, const Expr *Init,

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-03-30 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Seems fine to me, but you might want someone with analyzer experience to review. Repository: rC Clang https://reviews.llvm.org/D44238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-03-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: rsmith, doug.gregor, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. In code like const int &x = A().x; the destructor for `A()` was not present in the CFG due to two problems in the p