[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

jfb added a comment. In D44248#1391798 , @matthewbauer wrote: > This appears to be adding atomic on macOS builds, which shouldn't be > happening: > > https://hydra.nixos.org/build/88290234/ > > HAVE_CXX_ATOMICS64_WITHOUT_LIB is never being set. Odd.

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

matthewbauer added a comment. Herald added subscribers: kadircet, jfb, arphaman, atanasyan, jkorous. Herald added a project: LLVM. This appears to be adding atomic on macOS builds, which shouldn't be happening: https://hydra.nixos.org/build/88290234/ HAVE_CXX_ATOMICS64_WITHOUT_LIB is never

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

This revision was automatically updated to reflect the committed changes. Closed by commit rL329053: [clangd][cmake] Provide libatomic when there is no native support for 64bit… (authored by sdardis, committed by ). Herald added subscribers: llvm-commits, MaskRay. Changed prior to commit:

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

ioeric added a comment. In https://reviews.llvm.org/D44248#1041531, @sdardis wrote: > Thanks, I wasn't sure who to add as a reviewer. Authors/reviewers of recent patches for the same files are usually good approximations :) Repository: rCTE Clang Tools Extra

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

sdardis added a comment. Thanks, I wasn't sure who to add as a reviewer. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

ioeric added a comment. lgtm (Please add reviewers to your patch if you intend it to be reviewed.) Comment at: clangd/CMakeLists.txt:7 +if(NOT HAVE_CXX_ATOMICS64_WITHOUT_LIB) + list(APPEND CLANGD_ATOMIC_LIB atomic) +endif() nit: s/atomic/"atomic"/

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

sdardis added a comment. Ping? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

sdardis created this revision. Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, arichardson, mgorny, klimek. This addresses a persistent failure on clang-cmake-mips buildbot. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44248 Files: clangd/CMakeLists.txt