[PATCH] D44552: [Coroutines] Find custom allocators in class scope

2018-04-01 Thread Brian Gesiak via Phabricator via cfe-commits
modocache marked 2 inline comments as done. modocache added a comment. Thanks for the review, @GorNishanov! I adopted your suggestions and made the commit. Repository: rC Clang https://reviews.llvm.org/D44552 ___ cfe-commits mailing list

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

2018-04-01 Thread Brian Gesiak via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC328949: [Coroutines] Find custom allocators in class scope (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D44552?vs=138663=140600#toc Repository: rC Clang

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

2018-03-30 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM with some stylistic suggestions Comment at: lib/Sema/SemaExprCXX.cpp:2351 +return true; + else +LookupQualifiedName(R,

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

2018-03-16 Thread Brian Gesiak via Phabricator via cfe-commits
modocache created this revision. modocache added reviewers: GorNishanov, eric_niebler, lewissbaker. Herald added a subscriber: EricWF. https://reviews.llvm.org/rL325291 implemented Coroutines TS N4723 section [dcl.fct.def.coroutine]/7, but it performed lookup of allocator functions within both