[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

leonardchan added a comment. In D44672#1637984 , @vsk wrote: > In D44672#1637891 , @leonardchan > wrote: > > > It seems that this test leads to an `UNREACHABLE` under the new pass > > manager (can check this by

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

vsk added a comment. In D44672#1637891 , @leonardchan wrote: > It seems that this test leads to an `UNREACHABLE` under the new pass manager > (can check this by adding `-fexperimental-new-pass-manager` to the test. I > think this is because the passes

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

leonardchan added a comment. It seems that this test leads to an `UNREACHABLE` under the new pass manager (can check this by adding `-fexperimental-new-pass-manager` to the test. I think this is because the passes for lowering the `llvm.coro` intrinsics are not yet ported to the new PM. Would

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

modocache added a comment. Thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44672/new/ https://reviews.llvm.org/D44672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL368675: [CodeGen] Disable UBSan for coroutine functions (authored by modocache, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44672/new/ https://reviews.llvm.org/D44672

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

modocache updated this revision to Diff 214370. modocache added a comment. Thanks for the review, @vsk! Sorry it took me so long to update this diff. In the mailing list discussion, http://lists.llvm.org/pipermail/llvm-dev/2018-March/121925.html, you mentioned that I should use an allow-list

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

vsk requested changes to this revision. vsk added a comment. This revision now requires changes to proceed. Herald added a project: clang. (Marking this to reflect my comment from 3/20/18 to clear my review queue) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

modocache added a comment. Oh, I'm sorry I let this languish! I'll address your comments later this week, @vsk. Thanks so much for the review! Repository: rC Clang https://reviews.llvm.org/D44672 ___ cfe-commits mailing list

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

vsk added a comment. The "Cannot represent a difference across sections" error is almost certainly related to -fsanitize=function. Time permitting, could you file a separate PR for that and attach the IR? It'd be great to know whether the issue reproduces without coroutines involved. Also,

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

modocache created this revision. modocache added reviewers: GorNishanov, vsk, eric_niebler, lewissbaker. As explained in http://lists.llvm.org/pipermail/llvm-dev/2018-March/121924.html, the LLVM coroutines transforms are not yet able to move the instructions for UBSan null checking past coroutine