ormris abandoned this revision.
ormris added a comment.
I'm abandoning this revision based on some internal feedback. Thanks for the
review @JDevlieghere and @jingham!
Repository:
rC Clang
https://reviews.llvm.org/D44842
___
cfe-commits mailing
ormris added a comment.
No such luck...
Patch:
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
===
--- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
(revision 329079)
+++ source/P
ormris added a comment.
About to test with CPlusPlus14 enabled
Here's the output from those two commands.
(lldb) frame var -g crazy
error: no variable named 'crazy' found in this frame
(lldb) frame var -g crazy
error: no variable named 'crazy' found in this frame
(lldb)
Repositor
jingham added a comment.
Apparently this makes a global variable, so "frame var" wouldn't show it by
default. What does "frame var -g" show?
We would also need to get:
(lldb) frame var -g crazy
or something like it to work. "frame var" has its own parser to support "->"
and ".". That doe
ormris added a comment.
@jingham
Doesn't look like it works.
$ cat repro.cpp
template T crazy = T();
int main(void) {
crazy = 5;
return crazy;
}
$ clang++ -g repro.cpp
$ lldb a.out
...
(lldb) frame variable
(lldb) expr crazy
error: use of undeclared identifier 'cr
jingham added a comment.
@ormris Thanks! I you come up with some examples that test this, I can whip up
an lldb test case (or you can if you are feeling adventurous.) If you want to
try I'd be happy to give you a hand.
Repository:
rC Clang
https://reviews.llvm.org/D44842
__
ormris added a comment.
@jingham Will do.
Repository:
rC Clang
https://reviews.llvm.org/D44842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jingham added a comment.
I don't know off the top of my head. Did anybody working on this patch try
printing variables in lldb with this name change, particularly global
variables? Global lookups are particularly tricky, but it shouldn't be hard to
check. You'd want to check that you can pri
JDevlieghere added a comment.
@jingham is this safe to land?
Comment at: lib/CodeGen/CGDebugInfo.cpp:2992
+ std::string NameString = Name.str();
+ llvm::raw_string_ostream ParameterizedName(NameString);
+ ParameterizedName << "<";
ormris wrote:
>
ormris added a comment.
//Ping//
Repository:
rC Clang
https://reviews.llvm.org/D44842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ormris added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2992
+ std::string NameString = Name.str();
+ llvm::raw_string_ostream ParameterizedName(NameString);
+ ParameterizedName << "<";
JDevlieghere wrote:
> Why not use Name.str() dir
JDevlieghere added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2992
+ std::string NameString = Name.str();
+ llvm::raw_string_ostream ParameterizedName(NameString);
+ ParameterizedName << "<";
Why not use Name.str() directly?
Reposit
ormris added a project: debug-info.
ormris added a comment.
Adding debug-info project tag.
Repository:
rC Clang
https://reviews.llvm.org/D44842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
aprantl added a comment.
CC'ing LLDB developers because I'm not sure if this could break symbol lookup.
Repository:
rC Clang
https://reviews.llvm.org/D44842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
ormris created this revision.
ormris added reviewers: dblaikie, aprantl, probinson, JDevlieghere.
This patch adds the associated template parameters to the DWARF name attribute
of all template variable specializations, mirroring how they are referenced in
the source code.
Repository:
rC Clang
15 matches
Mail list logo
