[PATCH] D44901: [Diag] Avoid emitting a redefinition note if no location is available.

2018-03-28 Thread Matt Davis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC328712: [Diag] Avoid emitting a redefinition note if no location is available. (authored by mattd, committed by ). Repository: rC Clang https://reviews.llvm.org/D44901 Files: lib/Sema/SemaDecl.cpp

[PATCH] D44901: [Diag] Avoid emitting a redefinition note if no location is available.

2018-03-27 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D44901: [Diag] Avoid emitting a redefinition note if no location is available.

2018-03-26 Thread Matt Davis via Phabricator via cfe-commits
mattd created this revision. mattd added reviewers: bruno, rsmith. The "previous definition is here" note is not helpful if there is no location information. The note will reference nothing in such a case. This patch first checks to see if there is location data, and if so the note diagnostic is