[PATCH] D44921: [PowerPC] Option for secure plt mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL329795: [PowerPC] Option for secure plt mode (authored by spetrovic, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44921: [PowerPC] Option for secure plt mode

nemanjai added a subscriber: chmeee. nemanjai added a comment. In https://reviews.llvm.org/D44921#1056672, @spetrovic wrote: > -mbss-plt is currently default in LLVM, once secure plt support is finished > we can set secure plt as default in LLVM, but not for now. I was thinking in case the

[PATCH] D44921: [PowerPC] Option for secure plt mode

spetrovic added a comment. -mbss-plt is currently default in LLVM, once secure plt support is finished we can set secure plt as default in LLVM, but not for now. https://reviews.llvm.org/D44921 ___ cfe-commits mailing list

[PATCH] D44921: [PowerPC] Option for secure plt mode

nemanjai added a comment. In https://reviews.llvm.org/D44921#1050299, @joerg wrote: > GCC supports -mbss-plt to get the legacy behavior. Not sure if anyone > actually uses it though. @spetrovic Is this something we want to implement? https://reviews.llvm.org/D44921

[PATCH] D44921: [PowerPC] Option for secure plt mode

joerg added a comment. GCC supports -mbss-plt to get the legacy behavior. Not sure if anyone actually uses it though. https://reviews.llvm.org/D44921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44921: [PowerPC] Option for secure plt mode

spetrovic added a comment. Yes, secure PLT is PowerPC specific feature. https://reviews.llvm.org/D44921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44921: [PowerPC] Option for secure plt mode

spetrovic added inline comments. Comment at: include/clang/Driver/Options.td:1941 def mno_vsx : Flag<["-"], "mno-vsx">, Group; +def msecure_plt : Flag<["-"], "msecure-plt">, Group; def mpower8_vector : Flag<["-"], "mpower8-vector">, nemanjai wrote: > Do we not

[PATCH] D44921: [PowerPC] Option for secure plt mode

spetrovic updated this revision to Diff 140060. https://reviews.llvm.org/D44921 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h test/Driver/ppc-features.cpp Index: test/Driver/ppc-features.cpp

[PATCH] D44921: [PowerPC] Option for secure plt mode

nemanjai added a comment. I'll let Justin give the actual ACK, but this looks fine to me. The only question that I have (since I don't know anything about secure PLT) is whether this is a PPC-specific thing (since the option is a PPC option). Comment at:

[PATCH] D44921: [PowerPC] Option for secure plt mode

spetrovic created this revision. spetrovic added reviewers: jhibbits, nemanjai. Herald added a subscriber: kbarton. This patch enables option for secure plt mode in clang (-msecure-plt). This feature is supported in backend also (https://reviews.llvm.org/D42112).