This revision was automatically updated to reflect the committed changes.
Closed by commit rC329985: [XRay][clang] Add flag to choose instrumentation
bundles (authored by dberris, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44970?vs=142315&id=142317#toc
Repository:
rC
dberris updated this revision to Diff 142315.
dberris marked 5 inline comments as done.
dberris added a comment.
- fixup: Address comments
https://reviews.llvm.org/D44970
Files:
clang/include/clang/Basic/XRayInstr.h
clang/include/clang/Driver/Options.td
clang/include/clang/Driver/XRayArgs
dberris added a comment.
Thanks, Martin! Landing now, after suggested changes.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:471
bool CodeGenFunction::AlwaysEmitXRayCustomEvents() const {
- return CGM.getCodeGenOpts().XRayAlwaysEmitCustomEvents;
+ return CGM.getCodeGenOp
pelikan accepted this revision.
pelikan added a comment.
This revision is now accepted and ready to land.
Most of my comments are minor enough I'd be OK if this went in. But please
consider them before committing.
Comment at: clang/include/clang/Driver/XRayArgs.h:29
std::v
dberris updated this revision to Diff 141958.
dberris marked an inline comment as done.
dberris added a comment.
Herald added a subscriber: mgorny.
- Rebase
- Address comments to use a bitmask/bitset for instrumentation bundle
https://reviews.llvm.org/D44970
Files:
clang/include/clang/Basic/X
echristo added inline comments.
Comment at: clang/include/clang/Frontend/CodeGenOptions.h:110
+ enum XRayInstrumentationPointBundle {
+XRay_All, // Always emit all the instrumentation points.
dberris wrote:
> pelikan wrote:
> > To me, this feel
dberris updated this revision to Diff 140735.
dberris added a comment.
- fixup: Fix tests for better coverage of settings
https://reviews.llvm.org/D44970
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Driver/XRayArgs.h
clang/include/clang/Frontend/CodeGenOptions.def
cl
dberris added inline comments.
Comment at: clang/include/clang/Frontend/CodeGenOptions.h:110
+ enum XRayInstrumentationPointBundle {
+XRay_All, // Always emit all the instrumentation points.
pelikan wrote:
> To me, this feels like a bitfield wo
dberris updated this revision to Diff 140731.
dberris marked 8 inline comments as done.
dberris added a comment.
- fixup: address comments
https://reviews.llvm.org/D44970
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Driver/XRayArgs.h
clang/include/clang/Frontend/CodeGe
pelikan added a comment.
I would probably add more tests for the different configurations, but I suspect
more diffs are coming after this.
Comment at: clang/include/clang/Driver/Options.td:1112
+ Group, Flags<[CC1Option]>,
+ HelpText<"Select which bundle of XRay instrumentat
echristo added inline comments.
Comment at: clang/include/clang/Frontend/CodeGenOptions.h:113
+XRay_None,// Emit none of the instrumentation points.
+XRay_FunctionExtents, // Only emit function entry/exit instrumentation
+ // points.
-
dberris created this revision.
dberris added reviewers: echristo, kpw, eizan, pelikan.
This change addresses http://llvm.org/PR36926 by allowing users to pick
which instrumentation bundles to use, when instrumenting with XRay. In
particular, the flag `-fxray-instrumentation-bundle=` has four valid
12 matches
Mail list logo
