This revision was automatically updated to reflect the committed changes.
Closed by commit rC328871: [clang-format] Ensure wrapped ObjC selectors with 1
arg obey… (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44994?vs=140271=140436#toc
This revision was automatically updated to reflect the committed changes.
benhamilton marked an inline comment as done.
Closed by commit rL328871: [clang-format] Ensure wrapped ObjC selectors with 1
arg obey… (authored by benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
djasper accepted this revision.
djasper added a comment.
Looks good.
Repository:
rC Clang
https://reviews.llvm.org/D44994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benhamilton marked an inline comment as done.
benhamilton added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:904
+ : State.Stack.back().Indent);
if (NextNonComment->LongestObjCSelectorName == 0)
+return MinIndent;
benhamilton updated this revision to Diff 140271.
benhamilton added a comment.
Remove if (...) return MinIndent.
Repository:
rC Clang
https://reviews.llvm.org/D44994
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestObjC.cpp
Index:
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:904
+ : State.Stack.back().Indent);
if (NextNonComment->LongestObjCSelectorName == 0)
+return MinIndent;
benhamilton wrote:
> djasper wrote:
> > Does this
benhamilton updated this revision to Diff 140252.
benhamilton added a comment.
One more tidy-up
Repository:
rC Clang
https://reviews.llvm.org/D44994
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
benhamilton added a comment.
Thanks, applied your suggested change.
Comment at: lib/Format/ContinuationIndenter.cpp:899
if (!State.Stack.back().ObjCSelectorNameFound) {
+ unsigned MinIndent =
+ (Style.IndentWrappedFunctionNames
djasper
benhamilton updated this revision to Diff 140251.
benhamilton marked 2 inline comments as done.
benhamilton added a comment.
@djasper comments
Repository:
rC Clang
https://reviews.llvm.org/D44994
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestObjC.cpp
Index:
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:899
if (!State.Stack.back().ObjCSelectorNameFound) {
+ unsigned MinIndent =
+ (Style.IndentWrappedFunctionNames
I think I'd now find this slightly easier to read
jolesiak accepted this revision.
jolesiak added a comment.
This revision is now accepted and ready to land.
Well spotted.
Repository:
rC Clang
https://reviews.llvm.org/D44994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
benhamilton created this revision.
benhamilton added reviewers: djasper, klimek, Typz.
Herald added a subscriber: cfe-commits.
benhamilton added a reviewer: jolesiak.
In https://reviews.llvm.org/D43121, @Typz introduced logic to avoid indenting
2-or-more
argument ObjC selectors too far to the
12 matches
Mail list logo