whisperity added a comment.
Softly pinging this. Perhaps we could discuss this and get it in before Clang7
rides off into the sunset?
https://reviews.llvm.org/D45094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klimek added inline comments.
Comment at: lib/Basic/VirtualFileSystem.cpp:328
void OverlayFileSystem::pushOverlay(IntrusiveRefCntPtr FS) {
+ // FIXME: OverlayFS containing another one in its stack could be flattened.
FSList.push_back(FS);
ilya-biryukov
whisperity added a comment.
Pinging this as the talk has stalled.
https://reviews.llvm.org/D45094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
whisperity added inline comments.
Comment at: include/clang/Basic/VirtualFileSystem.h:315
+IntrusiveRefCntPtr
+createOverlayOnRealFilesystem(IntrusiveRefCntPtr TopFS);
+
ilya-biryukov wrote:
> NIT: I'm not an expert in English, but shouldn't it be
>
ilya-biryukov added inline comments.
Comment at: include/clang/Basic/VirtualFileSystem.h:315
+IntrusiveRefCntPtr
+createOverlayOnRealFilesystem(IntrusiveRefCntPtr TopFS);
+
NIT: I'm not an expert in English, but shouldn't it be
createOverlay**Over**Real.
ilya-biryukov added inline comments.
Comment at: include/clang/Basic/VirtualFileSystem.h:313
+/// \brief Creates a \p vfs::OverlayFileSystem which overlays the given file
+/// system above the 'real' file system, as seen by the operating system.
+IntrusiveRefCntPtr
whisperity updated this revision to Diff 141206.
whisperity added a comment.
Simplify the patch.
https://reviews.llvm.org/D45094
Files:
include/clang/Basic/VirtualFileSystem.h
include/clang/Tooling/Tooling.h
lib/Basic/VirtualFileSystem.cpp
lib/Tooling/Tooling.cpp
whisperity updated this revision to Diff 141204.
whisperity added a comment.
- Use an even more explicit way with the documentation requiring that the file
system should be an overlay.
- Add a method to easily overlay a `FileSystem` above the real one.
Repository:
rC Clang
ilya-biryukov added a comment.
Thanks, this patch raises a very good point. Having a VFS that is not overlayed
over RealFS is almost always the wrong thing to do.
On the other hand, I think it's useful to have the client code mention that it
overlays over real filesystem, rather than relying on
whisperity created this revision.
whisperity added reviewers: alexfh, klimek.
whisperity added a project: clang.
Herald added subscribers: dkrupp, rnkovacs.
This patch extends upon https://reviews.llvm.org/D41947 because the interface
that was landed from that patch isn't much user-friendly.
10 matches
Mail list logo
