[PATCH] D45109: Remove -cc1 option "-backend-option"

efriedma created this revision. Herald added subscribers: eraman, javed.absar, mehdi_amini. It means essentially the same thing as -mllvm; there isn't any reason to have separate options. Repository: rC Clang https://reviews.llvm.org/D45109 Files: include/clang/Driver/CC1Options.td incl

[PATCH] D45109: Remove -cc1 option "-backend-option"

efriedma added reviewers: pcc, echristo, rsmith. efriedma added a comment. Not sure who to add as reviewers here. Repository: rC Clang https://reviews.llvm.org/D45109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D45109: Remove -cc1 option "-backend-option"

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Uh sure. :) Though I'd almost do it the other way around. That said, -mllvm probably has more uptake. Repository: rC Clang https://reviews.llvm.org/D45109 _

[PATCH] D45109: Remove -cc1 option "-backend-option"

mcrosier accepted this revision. mcrosier added a comment. SGTM! Repository: rC Clang https://reviews.llvm.org/D45109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45109: Remove -cc1 option "-backend-option"

This revision was automatically updated to reflect the committed changes. Closed by commit rL329965: Remove -cc1 option "-backend-option". (authored by efriedma, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45109?vs=140484&id=142277

[PATCH] D45109: Remove -cc1 option "-backend-option"

george.karpenkov added subscribers: efriedma, george.karpenkov. george.karpenkov added a comment. Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-kext-mkernel.c ` file: ins

[PATCH] D45109: Remove -cc1 option "-backend-option"

efriedma added a subscriber: pcc. efriedma added a comment. The test wasn't checking anything useful; the clang driver never passes "-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 . -Eli Repository: rL LLVM https://reviews.llvm.org/D45109 _

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-kext-mkernel.c ` file: instead of changing the run lines to use -mllvm you have removed them. Was there a reason for the remo

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

The test wasn't checking anything useful; the clang driver never passes "-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 . -Eli On 4/12/2018 3:55 PM, George Karpenkov wrote: Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-ke