sberg added a comment.
see https://bugs.llvm.org/show_bug.cgi?id=37161 "clang-cl triggers
ASTContext::getASTRecordLayout Assertion `D && 'Cannot get layout of forward
declarations!''" for what appears to be fallout from this change
Repository:
rL LLVM
https://reviews.llvm.org/D45112
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329009: [MS] Emit vftable thunks for functions with
incomplete prototypes (authored by rnk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329009: [MS] Emit vftable thunks for functions with
incomplete prototypes (authored by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45112?vs=140499=140680#toc
Repository:
rnk added a comment.
In https://reviews.llvm.org/D45112#1053539, @majnemer wrote:
> Does this help PR25641?
I think so, these are probably duplicate PRs. I think your analysis on that bug
is slightly off, because the TU that provides `ImplCanvas::createColor` *can't*
provide the thunks that
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D45112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
majnemer added a comment.
Does this help PR25641?
https://reviews.llvm.org/D45112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk created this revision.
rnk added reviewers: rjmccall, rsmith, hans.
Herald added a subscriber: Prazek.
The following class hierarchy requires that we be able to emit a
this-adjusting thunk for B::foo in C's vftable:
struct Incomplete;
struct A {
virtual A* foo(Incomplete p) = 0;
};
